Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: normalizeUri and consolidate utils package 📦 #402

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

ramiAbdou
Copy link
Member

Description ✏️

This PR removes the normalize-url NPM packages and manually implements the normalizeUri function. It also gets used in the linkedInUrl validation.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Jul 22, 2024
@ramiAbdou ramiAbdou marked this pull request as ready for review July 22, 2024 21:48
@ramiAbdou ramiAbdou merged commit 399ff59 into main Jul 22, 2024
2 checks passed
@ramiAbdou ramiAbdou deleted the rami/url-formatting branch July 22, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant